From a3fa04596ab65bb9d080ba8acb991fae4976faf6 Mon Sep 17 00:00:00 2001 From: LingandRX Date: Wed, 14 May 2025 21:18:30 +0800 Subject: [PATCH] =?UTF-8?q?refactor:=20=E5=88=A0=E9=99=A4=E6=9C=AA?= =?UTF-8?q?=E4=BD=BF=E7=94=A8=E7=9A=84=E4=BB=A3=E7=A0=81=E5=92=8C=E6=B3=A8?= =?UTF-8?q?=E9=87=8A?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - 移除了 CollectionServiceImpl 中的 @Autowired 注解- 删除了 NoteController 中的未使用注释 - 注释掉了 QuestionListItemServiceImpl 中的未使用变量和方法调用 - 移除了 UserServiceImpl 中的未使用变量 --- .../example/copykamanotes/controller/NoteController.java | 1 - .../copykamanotes/service/impl/CollectionServiceImpl.java | 1 - .../service/impl/QuestionListItemServiceImpl.java | 6 +++--- .../example/copykamanotes/service/impl/UserServiceImpl.java | 3 +-- 4 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/main/java/com/example/copykamanotes/controller/NoteController.java b/src/main/java/com/example/copykamanotes/controller/NoteController.java index 45fc792..48422bd 100644 --- a/src/main/java/com/example/copykamanotes/controller/NoteController.java +++ b/src/main/java/com/example/copykamanotes/controller/NoteController.java @@ -89,7 +89,6 @@ public class NoteController { /** * 下载笔记 - * @return */ @GetMapping("/notes/download") public ApiResponse downloadNote() { diff --git a/src/main/java/com/example/copykamanotes/service/impl/CollectionServiceImpl.java b/src/main/java/com/example/copykamanotes/service/impl/CollectionServiceImpl.java index 4bd4305..06c5849 100644 --- a/src/main/java/com/example/copykamanotes/service/impl/CollectionServiceImpl.java +++ b/src/main/java/com/example/copykamanotes/service/impl/CollectionServiceImpl.java @@ -18,7 +18,6 @@ import com.example.copykamanotes.service.CollectionService; import com.example.copykamanotes.utils.ApiResponseUtils; import lombok.RequiredArgsConstructor; import org.springframework.beans.BeanUtils; -import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Service; import org.springframework.transaction.annotation.Transactional; diff --git a/src/main/java/com/example/copykamanotes/service/impl/QuestionListItemServiceImpl.java b/src/main/java/com/example/copykamanotes/service/impl/QuestionListItemServiceImpl.java index 72d7982..4da7680 100644 --- a/src/main/java/com/example/copykamanotes/service/impl/QuestionListItemServiceImpl.java +++ b/src/main/java/com/example/copykamanotes/service/impl/QuestionListItemServiceImpl.java @@ -33,10 +33,10 @@ import java.util.Set; public class QuestionListItemServiceImpl implements QuestionListItemService { private final QuestionListItemMapper questionListItemMapper; - private final QuestionListMapper questionListMapper; +// private final QuestionListMapper questionListMapper; private final RequestScopeData requestScopeData; private final NoteMapper noteMapper; - private final UserMapper userMapper; +// private final UserMapper userMapper; @Override public ApiResponse> userGetQuestionListItems(QuestionListItemQueryParams questionListItemQueryParams) { @@ -48,7 +48,7 @@ public class QuestionListItemServiceImpl implements QuestionListItemService { Integer questionListId = questionListItemQueryParams.getQuestionListId(); - QuestionList questionList = questionListMapper.findById(questionListId); +// QuestionList questionList = questionListMapper.findById(questionListId); List questionListItem = questionListItemMapper.findByQuestionListIdPage(questionListId, questionListItemQueryParams.getPageSize(), offset); List questionIds = questionListItem.stream().map(item -> item.getQuestion().getQuestionId()).toList(); diff --git a/src/main/java/com/example/copykamanotes/service/impl/UserServiceImpl.java b/src/main/java/com/example/copykamanotes/service/impl/UserServiceImpl.java index 9b91976..4abf0eb 100644 --- a/src/main/java/com/example/copykamanotes/service/impl/UserServiceImpl.java +++ b/src/main/java/com/example/copykamanotes/service/impl/UserServiceImpl.java @@ -43,7 +43,6 @@ public class UserServiceImpl implements UserService { private final JwtUtil jwtUtil; private final RequestScopeData requestScopeData; private final FileService fileService; - private final EmailService emailService; @Override @Transactional(rollbackFor = Exception.class) @@ -90,7 +89,7 @@ public class UserServiceImpl implements UserService { @Override public ApiResponse login(LoginRequest loginRequest) { - User user = null; + User user; if (loginRequest.getAccount() != null && !loginRequest.getAccount().isEmpty()) { user = userMapper.findByAccount(loginRequest.getAccount());