From 7ea50c9d522f475532484882dc9e4466b4828e37 Mon Sep 17 00:00:00 2001
From: LingandRX <rsgltzyd@hotmail.com>
Date: Mon, 30 Dec 2024 22:21:29 +0800
Subject: [PATCH] =?UTF-8?q?refactor(env=20and=20controllers):=20=E4=BC=98?=
 =?UTF-8?q?=E5=8C=96=E7=8E=AF=E5=A2=83=E5=8F=98=E9=87=8F=E9=85=8D=E7=BD=AE?=
 =?UTF-8?q?=E5=92=8C=E7=94=A8=E6=88=B7=E6=8E=A7=E5=88=B6=E5=99=A8=E9=80=BB?=
 =?UTF-8?q?=E8=BE=91?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- 添加 NODE_ENV 环境变量以指定开发环境
- 重构 httpStatus.js 文件的模块导出方式
- 修正用户控制器中的错误处理和消息返回
- 统一使用 messages 对象替代 successMessages
- 增加登录功能中的错误日志记录
---
 .env                          | 1 +
 common/constant/httpStatus.js | 2 +-
 controllers/userController.js | 9 ++++++---
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/.env b/.env
index 3c81611..80b898a 100644
--- a/.env
+++ b/.env
@@ -1,3 +1,4 @@
+NODE_ENV=development
 MONGO_ACCOUNT=mongo_yNWy6K
 MONGO_PASSWORD=mongo_pPGmE3
 SESSION_SECRET=secret
diff --git a/common/constant/httpStatus.js b/common/constant/httpStatus.js
index bdad8fa..b0b01d3 100644
--- a/common/constant/httpStatus.js
+++ b/common/constant/httpStatus.js
@@ -67,4 +67,4 @@ const HTTP_STATUS = {
   GATEWAY_TIMEOUT: 504
 }
 
-module.exports = HTTP_STATUS
+module.exports = { HTTP_STATUS }
diff --git a/controllers/userController.js b/controllers/userController.js
index 7ddb7bb..2b2f80b 100644
--- a/controllers/userController.js
+++ b/controllers/userController.js
@@ -37,7 +37,7 @@ exports.createUser = [
     try {
       const user = req.body
       await userService.create_user(user)
-      return FetchResult.formatResult(res, HTTP_STATUS.CREATED, successMessages.user.created)
+      return FetchResult.formatResult(res, HTTP_STATUS.CREATED, messages.user.created)
     } catch (err) {
       logger('Error creating user: ', err)
       if (err.message === messages.user.already_exists) {
@@ -77,11 +77,14 @@ exports.login = [
 
       const user = await userService.login(account, password)
       req.session.user = user
-      return FetchResult.formatResult(res, 200, successMessages.user.login)
+      return FetchResult.formatResult(res, 200, messages.user.login)
     } catch (err) {
       if (err.message === messages.user.not_found) {
         return FetchResult.formatResult(res, 401, messages.user.account_password_not_match)
       }
+
+      logger('Error logging in: ', err)
+
       return FetchResult.formatResult(
         res,
         HTTP_STATUS.INTERNAL_SERVER_ERROR,
@@ -100,7 +103,7 @@ exports.getUserExist = async (req, res) => {
     if (!exist) {
       return FetchResult.formatResult(res, 404, messages.user.not_found)
     }
-    return FetchResult.formatResult(res, 200, successMessages.user.exist)
+    return FetchResult.formatResult(res, 200, messages.user.exist)
   } catch (err) {
     logger('Error checking user existence: ', err)
     return FetchResult.formatResult(res, HTTP_STATUS.INTERNAL_SERVER_ERROR, 'Internal server error')