refactor(config): 优化 MongoDB配置文件

- 替换 dotenv 引入方式，使用 destructuring 导入 config 函数- 调用 config()函数以加载环境变量
-移除冗余的 import('dotenv').config() 语句

app.js

@@ -1,35 +1,20 @@
 import createError from 'http-errors'
-
 import express from 'express'
-
 import path from 'path'
-
 import logger from 'morgan'
-
 import cors from 'cors'
-
 import session from 'express-session'
-
 import { RedisStore } from 'connect-redis'
-
 import Redis from 'ioredis'
-
+import { fileURLToPath } from 'url'
 import cookieParser from 'cookie-parser'
-
-import indexRouter from './routes/index'
-
-import userRouter from './routes/userRouter'
-
-import accountRouter from './routes/accountRouter'
-
+import indexRouter from './routes/index.js'
+import userRouter from './routes/userRouter.js'
+import accountRouter from './routes/accountRouter.js'
 import { config } from 'dotenv'
-
-// mongodb数据库连接
-import { connectMongoDB } from './config/mongodbConfig'
-
-import { HTTP_STATUS } from './common/constant/httpStatus'
-
-import loginUtil from './utils/loginUtil'
+import { connectMongoDB } from './config/mongodbConfig.js'
+import { HTTP_STATUS } from './common/constant/httpStatus.js'
+import { authenticateSession } from './utils/loginUtil.js'
 
 config()
 // 初始化 Redis 客户端
@@ -42,6 +27,9 @@ const redisClient = new Redis({
 
 const app = express()
 
+const __filename = fileURLToPath(import.meta.url)
+const __dirname = path.dirname(__filename)
+
 app.use(logger('dev'))
 app.use(express.json())
 app.use(express.urlencoded({ extended: false }))
@@ -81,7 +69,7 @@ async function startServer() {
 startServer().then((r) => logger(r))
 
 app.use('/', indexRouter)
-app.use('/user', loginUtil.authenticateSession, userRouter)
+app.use('/user', authenticateSession, userRouter)
 app.use('/account', accountRouter)
 
 // catch 404 and forward to error handler
@@ -105,4 +93,4 @@ app.use(function (err, req, res) {
   })
 })
 
-module.exports = app
+export default app

bin/www

@@ -3,9 +3,9 @@
 /**
  * Module dependencies.
  */
-const app = require('../app')
-const debug = require('debug')('express:server')
-const http = require('http')
+import app from '../app.js'
+import debug from 'debug'
+import http from 'http'
 
 /**
  * Get port from environment and store in Express.

common/constant/httpStatus.js

@@ -66,5 +66,3 @@ export const HTTP_STATUS = {
   /** @type {number} 网关超时 */
   GATEWAY_TIMEOUT: 504
 }
-
-export default { HTTP_STATUS }

config/mongodbConfig.js

@@ -1,5 +1,4 @@
 import mongoose from 'mongoose'
-
 import logger from 'morgan'
 
 import { config } from 'dotenv'
@@ -16,7 +15,7 @@ let isConnected = false
 
 export async function connectMongoDB() {
   if (process.env.NODE_ENV === 'development') {
-    logger(account, password, host, port)
+    logger({ account, password, host, port })
   }
 
   // 如果已经连接，不再重复连接

controllers/userController.js

@@ -1,12 +1,12 @@
 import { body, validationResult } from 'express-validator'
 import logger from 'morgan'
-import userService from '../services/userService'
-import FetchResult from '../common/web/fetchResult'
-import messages from '../config/messages'
-import { HTTP_STATUS } from '../common/constant/httpStatus'
-import { SearchQuery } from '../models/search'
+import userService from '../services/userService.js'
+import FetchResult from '../common/web/fetchResult.js'
+import messages from '../config/messages.js'
+import { HTTP_STATUS } from '../common/constant/httpStatus.js'
+import { SearchQuery } from '../models/search.js'
 
-export default UserController = {
+const UserController = {
   async getAllUsers(res) {
     try {
       const users = await userService.getUserList()
@@ -15,7 +15,6 @@ export default UserController = {
       return FetchResult.formatResult(res, HTTP_STATUS.INTERNAL_SERVER_ERROR, 'Internal server error')
     }
   },
-
   async findUserList(req, res) {
     try {
       const { page, size, sort } = req.query
@@ -28,7 +27,6 @@ export default UserController = {
       return FetchResult.formatResult(res, HTTP_STATUS.INTERNAL_SERVER_ERROR, 'Internal server error')
     }
   },
-
   createUser: [
     body('account').isLength({ min: 3 }).withMessage('Account must be at least 3 characters long'),
     body('account').isEmpty().withMessage('Account is required'),
@@ -63,7 +61,6 @@ export default UserController = {
       }
     }
   ],
-
   login: [
     body('account').notEmpty().withMessage('Account is required'),
     body('password').notEmpty().withMessage('Password is required'),
@@ -99,7 +96,6 @@ export default UserController = {
       }
     }
   ],
-
   logout: [
     async (req, res) => {
       try {
@@ -111,7 +107,6 @@ export default UserController = {
       }
     }
   ],
-
   async getUserExists(req, res) {
     try {
       const { account } = req.query
@@ -126,5 +121,7 @@ export default UserController = {
       logger('Error checking user existence: ', err)
       return FetchResult.formatResult(res, HTTP_STATUS.INTERNAL_SERVER_ERROR, 'Internal server error')
     }
-  }
+  },
 }
+
+export default UserController

models/Search.js

@@ -7,7 +7,7 @@ export class SearchQuery {
   }
 }
 
-class SearchResult {
+export class SearchResult {
   constructor({ list = [], num = 0, size = 0, total = 0 } = {}) {
     if (typeof num !== 'number') {
       throw new Error('Invalid num parameter')
@@ -25,5 +25,3 @@ class SearchResult {
     this.total = total
   }
 }
-
-export default { SearchQuery, SearchResult }

models/userModel.js

@@ -1,5 +1,5 @@
 import { Schema as _Schema, model } from 'mongoose'
-import { hashPassword } from '../utils/hashUtils'
+import { hashPassword } from '../utils/hashUtils.js'
 const Schema = _Schema
 
 const UserSchema = new Schema({
@@ -7,12 +7,12 @@ const UserSchema = new Schema({
   gender: { type: String, enum: ['male', 'female', 'other'], maxlength: 20 },
   birth: { type: Date },
   avatar: { type: String, maxlength: 100 },
-  account: { type: String, required: true, unique: true, maxlength: 100, index: true },
+  account: { type: String, required: true, unique: true, maxlength: 100 },
   password: { type: String, required: true, maxlength: 100 },
-  email: { type: String, maxlength: 255, index: true },
-  phone: { type: String, maxlength: 11 },
+  email: { type: String, match: /^\S+@\S+\.\S+$/, maxlength: 255, index: true },
+  phone: { type: String, match: /^1[3-9]\d{9}$/, maxlength: 11 },
   registerDate: { type: Date, default: Date.now },
-  lastLoginDate: { type: Date, default: Date.now },
+  lastLoginDate: { type: Date },
   status: { type: String, enum: ['active', 'inactive', 'pending'], default: 'pending' }
 })
 
@@ -20,13 +20,18 @@ UserSchema.pre('save', async function (next) {
   const user = this
   if (!user.isModified('password')) return next()
   try {
-    console.log(user.password)
-
     user.password = await hashPassword(user.password)
     next()
   } catch (error) {
-    next(error)
+    // 记录错误日志，避免泄露敏感信息
+    console.error('Error hashing password:', error.message)
+    next(new Error('Failed to hash password'))
   }
 })
 
+// 更新 lastLoginDate 在用户登录时
+UserSchema.methods.updateLastLoginDate = function () {
+  this.lastLoginDate = new Date()
+}
+
 export default model('User', UserSchema)

repositories/userRepository.js

@@ -1,114 +1,93 @@
-import {
-  startSession,
-  find,
-  aggregate,
-  findById,
-  findOne,
-  exists,
-  create,
-  findByIdAndUpdate,
-  findByIdAndDelete,
-  deleteMany
-} from '../models/userModel'
-import { SearchResult } from '../models/search'
+import User from '../models/userModel.js'
+import { SearchResult } from '../models/search.js'
 
-export async function startTransaction() {
-  const session = await startSession()
-  session.startTransaction()
-  return session
-}
+const userRepository = {
+  async startTransaction() {
+    const session = await User.startSession()
+    session.startTransaction()
+    return session
+  },
+  async commitTransaction(session) {
+    return session.commitTransaction()
+  },
+  async rollbackTransaction(session) {
+    return session.abortTransaction()
+  },
+  async selectAllUser() {
+    return User.find()
+  },
+  async selectUserList(search = {}) {
+    try {
+      const { size = 20, page = 1, sort, filters } = search
 
-export async function commitTransaction(session) {
-  return session.commitTransaction()
-}
+      const skip = (page - 1) * size
+      const searchResult = new SearchResult()
+      searchResult.num = page
+      searchResult.size = size
 
-export async function rollbackTransaction(session) {
-  return session.abortTransaction()
-}
+      // 检查 filters，确保只有在 filters 存在时才应用
+      const matchFilters = filters ? { ...filters } : {}
 
-export async function selectAllUser() {
-  return find()
-}
+      const sortObj = sort && typeof sort === 'object' ? sort : { _id: 1 }
 
-export async function selectUserList(search = {}) {
-  try {
-    const { size = 20, page = 1, sort, filters } = search
-
-    const skip = (page - 1) * size
-    const searchResult = new SearchResult()
-    searchResult.num = page
-    searchResult.size = size
-
-    // 检查 filters，确保只有在 filters 存在时才应用
-    const matchFilters = filters ? { ...filters } : {}
-    const sortObj = sort && typeof sort === 'object' ? sort : { _id: 1 } // 默认按 _id 升序排序
-
-    const result = await aggregate([
-      // 应用过滤条件，确保filters存在时才传入
-      { $match: matchFilters },
-      {
-        $facet: {
-          metadata: [{ $count: 'total' }, { $addFields: { total: '$total' } }],
-          data: [{ $sort: sortObj }, { $skip: skip }, { $limit: size }]
+      const result = await User.aggregate([
+        // 应用过滤条件，确保filters存在时才传入
+        { $match: matchFilters },
+        {
+          $facet: {
+            metadata: [{ $count: 'total' }, { $addFields: { total: '$total' } }],
+            data: [{ $sort: sortObj }, { $skip: skip }, { $limit: size }]
+          }
         }
-      }
-    ])
+      ])
 
-    // 解构 result 并进行必要的空值检查
-    const { metadata = [], data = [] } = result[0] || {}
+      // 解构 result 并进行必要的空值检查
+      const { metadata = [], data = [] } = result[0] || {}
 
-    // 提取 metadata 中的 total，若不存在则为 0
-    searchResult.total = metadata.length > 0 ? metadata[0].total : 0
-    searchResult.list = data
+      // 提取 metadata 中的 total，若不存在则为 0
+      searchResult.total = metadata.length > 0 ? metadata[0].total : 0
+      searchResult.list = data
 
-    return searchResult
-  } catch (error) {
-    console.log(error)
-    throw error
+      return searchResult
+    } catch (error) {
+      console.log(error)
+      throw error
+    }
+  },
+  async selectUserById(id) {
+    return User.findById(id)
+  },
+  async selectUserByAccount(account) {
+    return User.findOne({ account: account })
+  },
+  async selectUserByEmail(email) {
+    return User.findOne({ email: email })
+  },
+  async selectUserByUsername(username) {
+    return User.findOne({ username: username })
+  },
+  async selectUserByPhone(phone) {
+    return User.findOne({ phone: phone })
+  },
+  async selectUserByAccountExist(account) {
+    const exist = await User.exists({ account: account })
+    return exist !== null
+  },
+  async createUser(user) {
+    return User.create(user)
+  },
+  async updateUserById(id, user) {
+    return User.findByIdAndUpdate(id, user)
+  },
+  async updateUserByLoginDate(id, loginDate) {
+    return User.findByIdAndUpdate(id, { lastLoginDate: loginDate })
+  },
+  async deleteUserById(id) {
+    return User.findByIdAndDelete(id)
+  },
+  async deleteAllUser() {
+    return User.deleteMany()
   }
 }
 
-export async function selectUserById(id) {
-  return findById(id)
-}
-
-export async function selectUserByAccount(account) {
-  return findOne({ account: account })
-}
-
-export async function selectUserByEmail(email) {
-  return findOne({ email: email })
-}
-
-export async function selectUserByUsername(username) {
-  return findOne({ username: username })
-}
-
-export async function selectUserByPhone(phone) {
-  return findOne({ phone: phone })
-}
-
-export async function selectUserByAccountExist(account) {
-  const exist = await exists({ account: account })
-  return exist !== null
-}
-
-export async function createUser(user) {
-  return create(user)
-}
-
-export async function updateUserById(id, user) {
-  return findByIdAndUpdate(id, user)
-}
-
-export async function updateUserByLoginDate(id, loginDate) {
-  return findByIdAndUpdate(id, { last_login_date: loginDate })
-}
-
-export async function deleteUserById(id) {
-  return findByIdAndDelete(id)
-}
-
-export async function deleteAllUser() {
-  return deleteMany()
-}
+export default userRepository

routes/accountRouter.js

@@ -1,9 +1,8 @@
-// routes/userRoutes.js
 import express from 'express'
-const userController = import('../controllers/userController')
+import userController from '../controllers/userController.js'
 
 const router = express.Router()
 
-router.get('/', getUserExists)
+router.get('/', userController.getUserExists)
 
 export default router

routes/index.js

@@ -1,6 +1,6 @@
 import express from 'express'
 
-import userController from '../controllers/userController'
+import userController from '../controllers/userController.js'
 
 const router = express.Router()
 router.get('/', function (req, res) {

routes/userRouter.js

@@ -1,7 +1,5 @@
-// routes/userRoutes.js
-import userController from '../controllers/userController'
-
 import express from 'express'
+import userController from '../controllers/userController.js'
 
 const router = express.Router()
 

services/userService.js

@@ -1,9 +1,9 @@
-import userMapper from '../repositories/userRepository'
+import userRepository from '../repositories/userRepository.js'
 import logger from 'morgan'
-import messages from '../config/messages'
-import { comparePassword } from '../utils/hashUtils'
+import messages from '../config/messages.js'
+import { comparePassword } from '../utils/hashUtils.js'
 
-export default userServeice = {
+const userService = {
   /**
    * 用户登录
    * @param {string} account - 用户账号
@@ -12,7 +12,7 @@ export default userServeice = {
    * @throws {Error} - 如果用户不存在或密码不正确
    */
   async login(account, password) {
-    const user = await userMapper.selectUserByAccount(account)
+    const user = await userRepository.selectUserByAccount(account)
 
     // 用户不存在
     if (!user) {
@@ -25,10 +25,6 @@ export default userServeice = {
       throw new Error(messages.user.passwordIncorrect)
     }
 
-    // 更新用户的最后登录时间
-    user.lastLoginDate = new Date()
-    await userMapper.updateUserByLoginDate(user.id, user.lastLoginDate)
-
     return user
   },
 
@@ -38,16 +34,16 @@ export default userServeice = {
    * @returns {Promise<boolean>}
    */
   async getUserExists(account) {
-    return userMapper.selectUserByAccountExist(account)
+    return userRepository.selectUserByAccountExist(account)
   },
 
   // Removed the unnecessary try-catch block and simplified the function
   async getAllUser() {
-    return await userMapper.selectAllUser()
+    return await userRepository.selectAllUser()
   },
 
   async getUserList(searchQuery) {
-    return userMapper.selectUserList(searchQuery)
+    return userRepository.selectUserList(searchQuery)
   },
 
   /**
@@ -58,27 +54,29 @@ export default userServeice = {
    */
   async createUser(user) {
     const { account } = user
-    const session = await userMapper.startTransaction()
+    const session = await userRepository.startTransaction()
 
     try {
       // 检查用户是否已存在
-      const existingUser = await userMapper.selectUserByAccount(account)
+      const existingUser = await userRepository.selectUserByAccount(account)
       if (existingUser) {
         return new Error(messages.user.alreadyExists)
       }
 
       // 创建新用户
-      const result = await userMapper.createUser(user)
+      const result = await userRepository.createUser(user)
 
       // 提交事务
-      await userMapper.commitTransaction(session)
+      await userRepository.commitTransaction(session)
       return result
     } catch (err) {
       // 回滚事务
-      await userMapper.rollbackTransaction(session).catch((rollbackErr) => {
+      await userRepository.rollbackTransaction(session).catch((rollbackErr) => {
         logger('Error rolling back transaction: ', rollbackErr)
       })
       throw err // 将错误抛给调用方（Controller 层）
     }
   }
 }
+
+export default userService

utils/hashUtils.js

@@ -5,7 +5,7 @@ import bcrypt from 'bcrypt'
  * @param {string} password 密码
  * @returns password 加密后的密码
  */
-async function hashPassword(password) {
+export async function hashPassword(password) {
   return bcrypt.hash(password, 10)
 }
 
@@ -18,5 +18,3 @@ async function hashPassword(password) {
 export async function comparePassword(password, hashedPassword) {
   return bcrypt.compare(password, hashedPassword)
 }
-
-export default { hashPassword, comparePassword }